fix memory leak by putting setInterval() in a useeffect #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…o try and keep the instruments page as small as possible
Tom-Willemsen
approved these changes
Nov 28, 2024
Member
Tom-Willemsen
left a comment
Tom-Willemsen
left a comment
There was a problem hiding this comment.
This refactor got a bit big!
Functionally, did leave a tab open on wall display overnight and didn't seem to use significantly more memory after a long time. Refactors look good although I didn't go through all with a fine-tooth comb...
Contributor
Author
|
it did, sorry, i got a bit carried away as I noticed a few issues with the wall display not updating sometimes etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80
this also fixes a bug that we witnessed a few weeks ago where POLREF got stuck in RESUMING on the wall display.